Fix lint issues #4545
Fix lint issues #4545
Conversation
For some reason, two lint violations show up on my computer when running `yarn lint:eslint`. I have attempted to remove `node_modules`, remove all `dist` directories, remove `.eslintcache`, run `yarn cache clear`, etc. to no avail. I think an ultimate fix here may be to upgrade ESLint packages but that would be a larger change, so as egregious as it is, this commit skirts around the issue by adding some ignore lines.
|
Did you try restarting your local TypeScript language server? |
|
@Mrtenz Yeah, I just tried closing my editor, running |
|
Not a huge fan of this idea. This type of rule exclusion prevents us from using the |
|
@Gudahtt Sure. I wanted to quickly unblock other people if they were encountering this, too, but I admit that this is probably not the best way to deal with this. Is there another way that you would suggest? Are you concerned that we don't currently have a good way to remove these later? |
|
I'd suggest that we investigate this further and find the root cause. I am not sure what you meant by your last question. |
|
@Gudahtt You mentioned the use of |
|
I mentioned that rule because enabling it would require undoing this change, leaving contributors in the same state of having local lint errors. |
Explanation
For some reason, two lint violations show up on my computer when running
yarn lint:eslint. I have attempted to removenode_modules, remove alldistdirectories, remove.eslintcache, runyarn cache clear, etc. to no avail. I think an ultimate fix here may be to upgrade ESLint packages but that would be a larger change, so as egregious as it is, this commit skirts around the issue by adding some ignore lines.References
Intermittent lint violations have been a problem for a long time. Also see #4540.
Changelog
(N/A)
Checklist